Skip to content

fix: expose community icon control on open relays#2640

Merged
wesbillman merged 1 commit into
mainfrom
carl/non-nip43-community-icon
Jul 23, 2026
Merged

fix: expose community icon control on open relays#2640
wesbillman merged 1 commit into
mainfrom
carl/non-nip43-community-icon

Conversation

@wesbillman

@wesbillman wesbillman commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expose the existing community icon editor when the active relay does not advertise NIP-43 membership enforcement
  • keep member-management controls gated to relay-reported owner/admin roles
  • share one fail-closed capability predicate between settings navigation and the icon card
  • rely on the existing kind 9033 relay authorization for the authoritative icon-write permission check

Why

The Block production relay is intentionally open and does not advertise NIP-43, so Desktop skips the membership snapshot and currently hides the icon editor even though the relay supports owner-signed kind 9033 icon updates.

This does not enable membership management on open relays and does not change relay admission semantics.

Verification

At commit 5ea82929cb28814c027c0640996870f9594d4722:

  • pnpm exec biome lint src/shared/api/relayMembers.ts src/shared/api/relayMembers.test.mjs src/features/settings/ui/SettingsView.tsx src/features/community-members/ui/CommunityMembersSettingsCard.tsx
  • pnpm typecheck
  • pnpm test — 3,462 passed before history-only rebase onto current main
  • git diff --check

@wesbillman
wesbillman requested a review from a team as a code owner July 23, 2026 22:41
@wesbillman
wesbillman force-pushed the carl/non-nip43-community-icon branch from a7dc11b to 21c0332 Compare July 23, 2026 22:43
Co-authored-by: npub1cl47vfhsqpqy9pwndphpm36vcp7vvz5h2js4qpqm5yewzj7nutkq7xyw8c <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: npub1cl47vfhsqpqy9pwndphpm36vcp7vvz5h2js4qpqm5yewzj7nutkq7xyw8c <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
@wesbillman
wesbillman force-pushed the carl/non-nip43-community-icon branch from 21c0332 to 5ea8292 Compare July 23, 2026 22:45
@wesbillman
wesbillman merged commit e341b09 into main Jul 23, 2026
25 checks passed
@wesbillman
wesbillman deleted the carl/non-nip43-community-icon branch July 23, 2026 23:13
brow pushed a commit that referenced this pull request Jul 24, 2026
…r-only

* origin/main: (28 commits)
  Clarify agent harness defaults in create flow (#2601)
  chore(mobile): relax release check (#2636)
  fix: expose community icon control on open relays (#2640)
  chore(release): release Buzz Desktop version 0.4.24 (#2627)
  feat: remember per-community navigation location (#2629)
  fix(desktop): suppress Windows console flashes and reject WSL bash alias (#2587)
  fix(desktop): fix Windows PATH clobber and .cmd shim EINVAL (#2563)
  Update SECURITY.md
  chore(mobile): lighter-weight release process (#2144)
  Gate default relay auto-connect behind release flag (#2589)
  fix(desktop): fast-track relay restart reconnects (#2579)
  fix(sharing): preserve agent/team snapshot tEXt chunks through media sanitization (#2438)
  fix(acp): restrict DM turns to owner and verified siblings (#2591)
  test(desktop): live relay kill/restart reconnect gate (#2583)
  fix(relay): send 1012 restart close to all clients on graceful drain (#2575)
  fix(desktop): retry failed initial relay dials (#2564)
  Refine channel lifecycle settings (#2427)
  Fix avatar upload lifecycle edge cases (#2277)
  fix(observer): eager archive hydration on panel open + 200-frame pages (#2574)
  fix(cli): install rustls crypto provider to unbreak WSS publishes in release builds (#2590)
  ...

Co-authored-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
Signed-off-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>

# Conflicts:
#	desktop/src-tauri/build.rs
#	desktop/src/features/agents/ui/AgentDefinitionDialog.tsx
#	desktop/src/testing/e2eBridge.ts
#	desktop/tests/helpers/bridge.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants